Transport: normalize CR/LF/CRLF and return single-line decoded identify; add robust monitoring#2
Merged
Merged
Conversation
chore(tests): add pytest suite mocking pyserial to verify SerialManager instantiates connections for all devices and probes without real hardware; cover failure tolerance and reconnect logic fix: clean serial_manager imports (use relative logger import)\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…ke establish_connections use per-device reconnect test: add backoff/reopen test and relax failing-open assertion; switch requirements.txt to pyserial to match pyproject Co-authored-by: openhands <openhands@all-hands.dev>
…h-serial-service\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…nd instantiate drivers via dynamic import; add shared SerialTransport and identify() in drivers; update tests to mock transport serial\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…oid repeated log lines\n\nCo-authored-by: openhands <openhands@all-hands.dev>
Refactor SerialManager to dynamic drivers + transport; add identify() and fix logger duplication
…fix manifest loading; support nested driver imports and tenma alias; adjust package imports Co-authored-by: openhands <openhands@all-hands.dev>
…kage; update dynamic loader and tests Co-authored-by: openhands <openhands@all-hands.dev>
…sconnected on no/failed response; reconnect every 2s Also fix manifest model selection fallback when model not provided. Co-authored-by: openhands <openhands@all-hands.dev>
…o str - Centralize decoding and EOL stripping in SerialTransport.read_until_reol - Update tests to accept extra Serial kwargs and to expect str identify() - Remove stray print in check_status; maintain reconnection semantics Co-authored-by: openhands <openhands@all-hands.dev>
…ndle CR, LF, CRLF consistently Co-authored-by: openhands <openhands@all-hands.dev>
… until configured EOL only Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Monitoring improvements (prev commits on this branch)
Tests
Why
Notes
Co-authored-by: openhands openhands@all-hands.dev